tkobayas commented on code in PR #6225:
URL:
https://github.com/apache/incubator-kie-drools/pull/6225#discussion_r1942525593
##########
drools-legacy-test-util/src/test/java/org/drools/mvel/CommonTestMethodBase.java:
##########
@@ -141,6 +143,14 @@ protected KieBase loadKnowledgeBaseFromString(
KnowledgeBuilderConfiguration con
return kbase;
}
+ public static String replaceAgendaGroupIfRequired(String drl) {
+ if (DrlParser.ANTLR4_PARSER_ENABLED) {
+ // new parser (DRL10) supports only ruleflow-group, dropping
agenda-group
+ return drl.replaceAll("agenda-group", "ruleflow-group");
+ }
+ return drl;
+ }
Review Comment:
`replaceAgendaGroupIfRequired` is defined in 3 places in this PR, because we
don't have a common test util module which can access `drools-drl-parser`.
- `kie-test-util` doesn't depend on any drools modules
- `drools-legacy-test-util` is meant be 'legacy' (to be removed)
I think this topic should be separated from this PR and I will consult
@pibizza .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
