tkobayas commented on code in PR #6225:
URL:
https://github.com/apache/incubator-kie-drools/pull/6225#discussion_r1942543475
##########
drools-test-coverage/test-suite/src/test/java/org/drools/testcoverage/common/util/KieUtil.java:
##########
@@ -94,19 +106,106 @@ public static KieFileSystem
getKieFileSystemWithKieModule(final KieModuleModel k
final ReleaseId
releaseId, final Resource... resources) {
final KieFileSystem fileSystem =
KieServices.Factory.get().newKieFileSystem();
fileSystem.generateAndWritePomXML(releaseId);
- for (final Resource resource : resources) {
+ for (Resource resource : resources) {
+ resource = newResourceForNewParserIfRequired(resource);
fileSystem.write(resource);
}
fileSystem.writeKModuleXML(kieModuleModel.toXML());
return fileSystem;
}
+ private static Resource newResourceForNewParserIfRequired(Resource
resource) {
Review Comment:
This method is used for the new parser testing (not enabled by default).
Actually, only to convert `agenda-group` to `ruleflow-group` because
`agenda-group` is not allowed in DRL10, but it's widely used in the test cases
(cannot manage with `@DisabledIfSystemProperty`). When we drop DRL6 in the
future, we will be able to fully replace `agenda-group` in test cases and
remove this conversion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
