wmedvede commented on code in PR #2911:
URL:
https://github.com/apache/incubator-kie-tools/pull/2911#discussion_r1965732577
##########
packages/sonataflow-operator/internal/controller/profiles/preview/deployment_handler.go:
##########
@@ -73,6 +83,10 @@ func (d *DeploymentReconciler) reconcileWithImage(ctx
context.Context, workflow
if _, err := d.PerformStatusUpdate(ctx, workflow); err != nil {
return reconcile.Result{Requeue: false}, nil, err
}
+
+ if err := d.notifyStatusUpdate(ctx, workflow, previousStatus); err !=
nil {
+ return reconcile.Result{Requeue: false}, nil, err
+ }
Review Comment:
metadata.generation changes only when we have changes in the spec, and we
might have scenarios where only the status changes in this recon. But also, a
potential new generation is generated only when the CR is updated, I think we
would need a second read as part of current recon to have the old and the just
produced new number. I think, that since we are modifying the status at this
point, this approach is better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
