wmedvede commented on code in PR #2911:
URL:
https://github.com/apache/incubator-kie-tools/pull/2911#discussion_r2004942722
##########
packages/sonataflow-operator/internal/controller/platform/services/services.go:
##########
@@ -690,7 +693,7 @@ func (d *DataIndexHandler)
GenerateKnativeResources(platform *operatorapi.Sonata
d.newTrigger(lbl, annotations, brokerName, namespace,
serviceName, "process-node", "ProcessInstanceNodeDataEvent",
constants.KogitoProcessInstancesEventsPath, platform),
d.newTrigger(lbl, annotations, brokerName, namespace,
serviceName, "process-state", "ProcessInstanceStateDataEvent",
constants.KogitoProcessInstancesEventsPath, platform),
d.newTrigger(lbl, annotations, brokerName, namespace,
serviceName, "process-variable", "ProcessInstanceVariableDataEvent",
constants.KogitoProcessInstancesEventsPath, platform),
- d.newTrigger(lbl, annotations, brokerName, namespace,
serviceName, "process-definition", "ProcessDefinitionEvent",
constants.KogitoProcessDefinitionsEventsPath, platform),
+ d.newTrigger(lbl, managedAnnotations, brokerName, namespace,
serviceName, "process-definition", "ProcessDefinitionEvent",
constants.KogitoProcessDefinitionsEventsPath, platform),
Review Comment:
That's a good question. Until now, only the runtime produced that event, and
only one. So, no issue.
Now, the operator is sending it too, and, since the operator might retry the
sending, or if the WF is deployed and un-deployed fast, etc., the operator
might produce that event many times. So I think the casuistic was introduced
now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
