ljmotta commented on code in PR #2902:
URL:
https://github.com/apache/incubator-kie-tools/pull/2902#discussion_r2001464676
##########
packages/dmn-editor/src/propertiesPanel/BkmProperties.tsx:
##########
@@ -29,10 +29,11 @@ import { useDmnEditorStore, useDmnEditorStoreApi } from
"../store/StoreContext";
import { InlineFeelNameInput } from "../feel/InlineFeelNameInput";
import { useDmnEditor } from "../DmnEditorContext";
import { useResolvedTypeRef } from "../dataTypes/useResolvedTypeRef";
-import { useCallback, useMemo } from "react";
+import { useCallback, useMemo, useState } from "react";
Review Comment:
Leftover
##########
packages/dmn-editor/tests-e2e/drgElements/checkDecisionNodeProperties.spec.ts:
##########
Review Comment:
Please, add the test in the `changeDecisionProperties` file
##########
packages/dmn-editor/src/propertiesPanel/DecisionProperties.tsx:
##########
@@ -29,10 +29,11 @@ import { useDmnEditorStore, useDmnEditorStoreApi } from
"../store/StoreContext";
import { InlineFeelNameInput } from "../feel/InlineFeelNameInput";
import { useDmnEditor } from "../DmnEditorContext";
import { useResolvedTypeRef } from "../dataTypes/useResolvedTypeRef";
-import { useCallback, useMemo } from "react";
+import { useCallback, useMemo, useState } from "react";
Review Comment:
Same
##########
packages/dmn-editor/tests-e2e/__fixtures__/propertiesPanel/propertiesPanelBase.ts:
##########
@@ -30,6 +30,10 @@ export abstract class PropertiesPanelBase {
return
this.page.getByTestId("kie-tools--dmn-editor--properties-panel-container");
}
+ public beepanel() {
+ return
this.page.getByTestId("kie-tools--dmn-editor--bee-properties-panel-container");
+ }
+
Review Comment:
You don't need to add this method. You can use the `BeePropertiesPanelBase`
`panel` method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
