jomarko commented on code in PR #2902:
URL:
https://github.com/apache/incubator-kie-tools/pull/2902#discussion_r2002765974
##########
packages/dmn-editor/tests-e2e/__fixtures__/propertiesPanel/decisionPropertiesPanel.ts:
##########
@@ -82,18 +90,35 @@ export class DecisionPropertiesPanel extends
PropertiesPanelBase {
await this.panel().getByPlaceholder("Enter a question...").press("Tab");
}
+ public async setDecisionQuestion(args: { newQuestion: string }) {
+ await this.beepanel().getByPlaceholder("Enter a
question...").fill(args.newQuestion);
+ await this.beepanel().getByPlaceholder("Enter a question...").press("Tab");
+ }
+
public async getQuestion() {
return await this.panel().getByPlaceholder("Enter a
question...").inputValue();
}
+ public async getDecisionQuestion() {
+ return await this.beepanel().getByPlaceholder("Enter a
question...").inputValue();
+ }
+
public async setAllowedAnswers(args: { newAllowedAnswers: string }) {
await this.panel().getByPlaceholder("Enter allowed
answers...").fill(args.newAllowedAnswers);
await this.panel().getByPlaceholder("Enter allowed
answers...").press("Tab");
}
+ public async setDecisionAllowedAnswers(args: { newAllowedAnswers: string }) {
+ await this.beepanel().getByPlaceholder("Enter allowed
answers...").fill(args.newAllowedAnswers);
+ await this.beepanel().getByPlaceholder("Enter allowed
answers...").press("Tab");
+ }
+
public async getAllowedAnswers() {
return await this.panel().getByPlaceholder("Enter allowed
answers...").inputValue();
}
+ public async getDecisionAllowedAnswers() {
+ return await this.beepanel().getByPlaceholder("Enter allowed
answers...").inputValue();
+ }
Review Comment:
I think I do not understand the naming convestion used here,
- `setDecisionXXX`
- `getDecisionXXX`
why not only:
- `setXXX`
- `getXXX`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
