gitgabrio commented on code in PR #3935:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/3935#discussion_r2104508686
##########
drools/kogito-pmml-openapi/src/main/java/org/kie/kogito/pmml/openapi/PMMLOASUtils.java:
##########
@@ -29,19 +29,8 @@
import org.kie.pmml.api.models.Interval;
import org.kie.pmml.api.models.MiningField;
-import com.fasterxml.jackson.databind.node.ArrayNode;
-import com.fasterxml.jackson.databind.node.BigIntegerNode;
-import com.fasterxml.jackson.databind.node.DecimalNode;
-import com.fasterxml.jackson.databind.node.DoubleNode;
-import com.fasterxml.jackson.databind.node.FloatNode;
-import com.fasterxml.jackson.databind.node.IntNode;
-import com.fasterxml.jackson.databind.node.LongNode;
-import com.fasterxml.jackson.databind.node.NumericNode;
-import com.fasterxml.jackson.databind.node.ObjectNode;
-import com.fasterxml.jackson.databind.node.ShortNode;
-import com.fasterxml.jackson.databind.node.TextNode;
-
-import io.smallrye.openapi.runtime.io.JsonUtil;
+import com.fasterxml.jackson.databind.ObjectMapper;
+import com.fasterxml.jackson.databind.node.*;
Review Comment:
IIRC, we should avoid wildcard (`.*`) imports
##########
drools/kogito-pmml-openapi/src/main/java/org/kie/kogito/pmml/openapi/PMMLOASUtils.java:
##########
@@ -62,9 +51,20 @@ public class PMMLOASUtils {
public static final String INFINITY_SYMBOL = new
String(Character.toString('\u221E').getBytes(StandardCharsets.UTF_8),
StandardCharsets.UTF_8);
+ private static final ObjectMapper MAPPER = new ObjectMapper();
Review Comment:
This seems unused
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
