ricardozanini commented on code in PR #3935: URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3935#discussion_r2109243979
########## quarkus/bom/pom.xml: ########## @@ -36,10 +36,6 @@ <name>Kogito :: Quarkus :: BOM</name> <description>Internal BOM descriptor for Kogito modules targeting Quarkus use-cases. Specific dependencies targeting the Quarkus platform must be added here.</description> - <properties> - <!-- Keep it aligned with https://github.com/quarkusio/quarkus/blob/3.15/pom.xml#L72 --> - <version.io.fabric8.kubernetes-client>6.13.4</version.io.fabric8.kubernetes-client> Review Comment: Fabric8 on Spring and Quarkus differs from time to time. It's a good practice to keep these versions on separate BOMs (SB and Quarkus). ########## quarkus/addons/persistence/infinispan/health/src/test/java/org/kie/kogito/infinispan/health/InfinispanHealthCheckIT.java: ########## @@ -34,6 +35,7 @@ @QuarkusTest @QuarkusTestResource(InfinispanQuarkusTestResource.class) +@Disabled("Disabled because of agreement to remove Infinispan code https://lists.apache.org/thread/zdhdyzrzqrp4v25btloyfgk60bry4stz";) Review Comment: Why not remove this module completely? It will be done in a later PR? ########## quarkus/addons/fabric8-kubernetes-service-catalog/runtime/src/test/java/org/kie/kogito/addons/quarkus/fabric8/k8s/service/catalog/OpenShiftServiceDiscoveryTest.java: ########## @@ -39,7 +39,7 @@ import static org.junit.jupiter.api.Assertions.assertEquals; @QuarkusTest -@QuarkusTestResource(OpenShiftMockServerTestResource.class) +@QuarkusTestResource(KubernetesMockServerTestResource.class) // Changed to use KubernetesMockServerTestResource public class OpenShiftServiceDiscoveryTest { Review Comment: Please note that this test specifically verifies OpenShift resources such as Route and DeploymentConfig. I'm ok with this change if it passes the tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
