gitgabrio commented on PR #6352: URL: https://github.com/apache/incubator-kie-drools/pull/6352#issuecomment-2911439196
@mariofusco Point is not about "adding one more quarkus extension could bring any damage to spring support." Point is about maintainability and architectural cleanness. 1. in recent past we had harsh discussion, in community, about repository refactoring; root issue resolving about the inconsistency of our repositories in terms of scope and architectural layer; I repeat, drools repo should be the library framework-agnostic level (as it was enforced years ago exactly by you, by the way 😄 ) 2. having quarkus dependency inside drools has, as consequence, the fact that whatever change we need to make related to quarkus, it involves also this repositories, increasing uselessy the effort and time required (see the long and sad history of this [PR](https://github.com/apache/incubator-kie-drools/pull/6356), as example ) 3. another consequence is that, having quarkus inside drools, all the versions of the libraries inherited by it, have to be declared in the same common bom; and that lead to a clash whenever the same libraries are inherited also from springboot; e.g. quarkus X requires some:library:10, so some:library:10 is declared in the common bom springboot Y requires some:library:11, so, downstream, an exclude workaround has to be implemented for all the springboot cases; and, often, it is not a matter of a single library but most of a network of libraries. And, again, this eventually resolve in increased cost to maintain and also brittleness of our codebase. This, ultimately, is the consequence of having built our codebase around quarkus as primary target, and then managed springboot in sort of "workaround mode". Last, but not least, being all our codebase a de-facto monolith (in terms of release), for users it does not make any difference in which repository a given module is written -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
