gitgabrio commented on PR #6352: URL: https://github.com/apache/incubator-kie-drools/pull/6352#issuecomment-2918591366
@mariofusco > it seems to me that this discussion is out of the scope of this PR and this PR itself doesn't change the current situation in any way. Do you agree? Nope, I disagree. 😄 , meaning that whenever there are bigger implications (i.e. architectural considerations) behind a PR, we can't simply ignore them because the classes modified are a lower arch level; sorry, this is a bad approach that has been taken a lot of time, result being a sort of messy overall situation (my POV - IMHO). Anyway, I did not put any review on this PR, to not block it. @porcelli Of course @mariofusco will provide better inside, but there are some elephants in the room: 1. RuleUnit is not battle-tested as the classic approach - and reliability is THE critical factor for users that need to deliver stable products 2. moving RuleUnit to the same level of test covering and battle-field verification of the classic approach would require an effort (in terms of time and resources) that probably right now we could not afford 3. side-note: it is not 100% clear, to me, what cases and actual improvements the "RuleUnit" approach is bringing, and if those are still relevant in the "kogito" era m2c -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
