fantonangeli commented on code in PR #3167:
URL:
https://github.com/apache/incubator-kie-tools/pull/3167#discussion_r2124348170
##########
packages/sonataflow-image-common/resources/modules/kogito-maven/common/module.yaml:
##########
@@ -23,16 +23,20 @@ version: "main"
envs:
- name: "MAVEN_VERSION"
description: "The Maven version to setup with this module"
+ value: "3.8.6"
- name: "MAVEN_HOME"
value: "/usr/share/maven"
- name: "MAVEN_CMD"
- value: "/usr/share/maven/bin/mvnw"
+ value: "/usr/share/maven/bin/mvn"
- name: "MAVEN_SETTINGS_PATH"
description: "The location of the settings.xml file"
value: "${KOGITO_HOME}/.m2/settings.xml"
- name: "MAVEN_CONTAINER_BUILD_SETTINGS_PATH"
description: "The location of the settings.xml file during container image
build"
value: "${KOGITO_HOME}/.m2/maven-m2-repo-via-http-settings.xml"
+ - name: "KOGITO_MAVEN_HOME"
Review Comment:
But we are not using a maven wrapper in this PR. Instead, we are using a
full installation from:
https://archive.apache.org/dist/maven/maven-3/3.8.6/binaries/apache-maven-3.8.6-bin.tar.gz
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
