ljmotta commented on code in PR #3223:
URL:
https://github.com/apache/incubator-kie-tools/pull/3223#discussion_r2262961575
##########
packages/i18n-common-dictionary/src/locales/de.ts:
##########
@@ -81,5 +81,34 @@ export const de: CommonI18n = {
uninstall: "Deinstallieren",
username: "Username",
validation: "Validierung",
+ keyboardShortCuts: {
+ ctrlC: "",
+ ctrlX: "",
+ ctrlV: "",
+ ctrl: "",
+ escape: "",
+ backspace: "",
+ delete: "",
+ up: "",
+ down: "",
+ left: "",
+ right: "",
+ a: "",
+ x: "",
+ g: "",
+ i: "",
+ h: "",
+ b: "",
+ shiftUp: "",
+ shiftDown: "",
+ shiftLeft: "",
+ shiftRight: "",
+ space: "",
+ shift: "",
+ edit: "",
+ misc: "",
+ move: "",
+ navigate: "",
+ },
Review Comment:
We shouldn't add anything for this case. `i18n` will automatically fallback
to `en` dictionary.
##########
packages/dmn-editor-envelope/src/DmnEditorFactory.tsx:
##########
@@ -189,6 +191,7 @@ export function DmnEditorRootWrapper({
isReadOnly={isReadOnly}
isImportDataTypesFromJavaClassesSupported={isImportDataTypesFromJavaClassesSupported}
javaCodeCompletionService={javaCodeCompletionService}
+ i18n={i18n}
Review Comment:
```tsx
<I18nDictionariesProvider
defaults={dmnEditorEnvelopeI18nDefaults}
dictionaries={dmnEditorEnvelopeI18nDictionaries}
initialLocale={navigator.language}
ctx={DmnEditorEnvelopeI18nContext}
>
<DmnEditorRoot ... />
</I18nDictionariesProvider>
```
##########
packages/dmn-editor-envelope/src/DmnEditorFactory.tsx:
##########
@@ -189,6 +191,7 @@ export function DmnEditorRootWrapper({
isReadOnly={isReadOnly}
isImportDataTypesFromJavaClassesSupported={isImportDataTypesFromJavaClassesSupported}
javaCodeCompletionService={javaCodeCompletionService}
+ i18n={i18n}
Review Comment:
You should've added the `I18nDictionariesProvider` before `DmnEditorRoot`,
so you can use the `const { i18n } = useDmnEditorEnvelopeI18n();` hook on the
`DmnEditorRoot` component.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
