ljmotta commented on code in PR #3223:
URL:
https://github.com/apache/incubator-kie-tools/pull/3223#discussion_r2290988094
##########
packages/i18n-common-dictionary/src/CommonI18n.ts:
##########
@@ -79,6 +79,35 @@ export type CommonDictionary = {
uninstall: string;
username: string;
validation: string;
+ keyboardShortCuts: {
+ ctrlC: string;
+ ctrlX: string;
+ ctrlV: string;
+ ctrl: string;
+ escape: string;
+ backspace: string;
+ delete: string;
+ up: string;
+ down: string;
+ left: string;
+ right: string;
+ a: string;
+ x: string;
+ g: string;
+ i: string;
+ h: string;
+ b: string;
+ shiftUp: string;
+ shiftDown: string;
+ shiftLeft: string;
+ shiftRight: string;
+ space: string;
+ shift: string;
+ edit: string;
+ misc: string;
+ move: string;
+ navigate: string;
+ };
Review Comment:
I believe the correct separation would be:
- `keyboardKeys` for the keyboard keys.
- The sections (`edit`, `misc`, etc) should be on the specific dictionary
of the package that will use it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
