yesamer commented on code in PR #6519:
URL:
https://github.com/apache/incubator-kie-drools/pull/6519#discussion_r2533073405
##########
kie-dmn/kie-dmn-feel/src/test/java/org/kie/dmn/feel/lang/ast/InfixOperatorTest.java:
##########
@@ -23,7 +23,12 @@
import java.time.temporal.ChronoUnit;
import org.junit.jupiter.api.Test;
+import org.kie.dmn.api.core.DMNVersion;
import org.kie.dmn.feel.lang.EvaluationContext;
+import org.kie.dmn.feel.lang.FEELDialect;
+import org.kie.dmn.feel.lang.impl.EvaluationContextImpl;
+import org.kie.dmn.feel.lang.impl.FEELEventListenersManager;
+import org.kie.dmn.feel.util.ClassLoaderUtil;
Review Comment:
@ChinchuAjith Are those imports necessary?
##########
kie-dmn/kie-dmn-feel/src/test/java/org/kie/dmn/feel/runtime/BFEELTest.java:
##########
@@ -50,60 +52,64 @@ protected void instanceTest(String expression, Object
result, FEELEvent.Severity
}
private static Collection<Object[]> data() {
- final Object[][] cases = new Object[][] {
- {"\"a\" = 1", false, null},
- {"\"a\" != 1", true, null},
- {"\"a\" < 1", false, null},
- {"\"a\" <= null", false, null},
- {"\"a\" > 1", false, null},
- {"null >= 1", false, null},
- {"not(\"a\")", false, null},
- {"true and \"x\"", false, null},
- {"false or \"x\"", false, null},
- {"\"a\" in [1..100]", false, null},
- {"null between 1 and 100", false, FEELEvent.Severity.ERROR},
-
- {"matches(\"bad pattern\",\"[0-9\")", false, null},
- {"before(date(\"2021-01-01\"), null)", false, null},
- {"all(true,\"x\",true)", false, null},
- {"any(null)", false, null},
-
- {"decimal(\"a\", 0)", BigDecimal.ZERO,
FEELEvent.Severity.ERROR},
- {"round up(\"5.5\", 0)", BigDecimal.ZERO,
FEELEvent.Severity.ERROR},
- {"string length(22)", BigDecimal.ZERO,
FEELEvent.Severity.ERROR},
- {"day of year(\"a\")", BigDecimal.ZERO,
FEELEvent.Severity.ERROR},
- {"count([1,null,3])", BigDecimal.valueOf(3), null},
- {"sum([1, null, 3])", BigDecimal.valueOf(4), null},
- {"sum([1, \"1\" ,3])", BigDecimal.valueOf(4), null},
- {"sum([])", BigDecimal.ZERO, null},
- {"mean([\"a\"])", BigDecimal.ZERO, null},
- {"mean([1, \"a\", 3])", BigDecimal.valueOf(2), null},
-
- {"lower case(12)", "", FEELEvent.Severity.ERROR},
- {"string(null)", "", null},
- {"day of week(\"a\")", "", FEELEvent.Severity.ERROR},
- {"substring(\"a\", \"z\")", "", FEELEvent.Severity.ERROR},
-
- {"time(\"a\")", OffsetTime.of(0, 0, 0, 0,
ZoneOffset.ofHoursMinutes(0, 0)), null},
- {"date(null)", LocalDate.of(1970, 1, 1), null},
-
- {"duration(\"a\")", ComparablePeriod.parse("P0M" ) , null},
- {"years and months duration(null, null)",
ComparablePeriod.parse("P0M" ) , null},
-
- {"split(\"abc\", 22)", Collections.emptyList(),
FEELEvent.Severity.ERROR},
- {"mode([null,null,null, 1, 1, 2])", List.of(BigDecimal.ONE),
null},
-
- {"range(\"[x]\")", new RangeImpl(Range.RangeBoundary.OPEN,
BigDecimal.ZERO, BigDecimal.ZERO, Range.RangeBoundary.OPEN), null},
-
- {"number(\"test\")", BigDecimal.ZERO, null},
- {"number(\"1 2 3\")", BigDecimal.ZERO, null},
- {"number(\"1.1\")", BigDecimal.valueOf(1.1), null},
-
- {"number(\"test\", null, null)", BigDecimal.ZERO, null},
- {"number(\"1234\", null, null)", BigDecimal.valueOf(1234),
null},
- {"number(\"1 234 000\", \" \" , null)",
BigDecimal.valueOf(1234000), null},
- {"number(\"1,234\", \",\" , null)", BigDecimal.valueOf(1234),
null},
+ final Object[][] cases = new Object[][] { { "\"a\" = 1", false, null
}, { "\"a\" != 1", true, null },
+ { "\"a\" < 1", false, null }, { "\"a\" <= null", false, null
}, { "\"a\" > 1", false, null },
+ { "null >= 1", false, null }, { "not(\"a\")", false, null }, {
"true and \"x\"", false, null },
+ { "false or \"x\"", false, null }, { "\"a\" in [1..100]",
false, null },
+ { "null between 1 and 100", false, FEELEvent.Severity.WARN },
Review Comment:
@ChinchuAjith If I'm not wrong, it looks like this file you changed the
formatting only. Why that? I would suggest keeping the original formatting if
there is no specific reason to change it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
