ChinchuAjith commented on code in PR #6519:
URL:
https://github.com/apache/incubator-kie-drools/pull/6519#discussion_r2540558453
##########
kie-dmn/kie-dmn-feel/src/main/java/org/kie/dmn/feel/lang/ast/infixexecutors/AndExecutor.java:
##########
@@ -37,23 +37,21 @@ public static AndExecutor instance() {
@Override
public Object evaluate(Object left, Object right, EvaluationContext ctx) {
- return and(left, right, ctx);
+ DialectHandler handler = DialectHandlerFactory.getHandler(ctx);
+ return handler.executeAnd(left, right, ctx);
}
@Override
public Object evaluate(InfixOpNode infixNode, EvaluationContext ctx) {
- Boolean leftAND =
BooleanEvalHelper.getBooleanOrDialectDefault(infixNode.getLeft().evaluate(ctx),
-
ctx.getFEELDialect());
- if (leftAND != null) {
- if (leftAND.booleanValue()) {
- return
BooleanEvalHelper.getBooleanOrDialectDefault(infixNode.getRight().evaluate(ctx),
-
ctx.getFEELDialect());
- } else {
- return Boolean.FALSE; //left hand operand is false, we do not
need to evaluate right side
- }
- } else {
- return
BooleanEvalHelper.getFalseOrDialectDefault(infixNode.getRight().evaluate(ctx),
ctx.getFEELDialect());
+ Object leftRaw = infixNode.getLeft().evaluate(ctx);
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
