Re: [PR] kie-issues#1127: New swf-editor package ts / react / react flow [incubator-kie-tools]

Mon, 24 Nov 2025 19:50:09 -0800 


handreyrc commented on PR #3252:
URL: 
https://github.com/apache/incubator-kie-tools/pull/3252#issuecomment-3573672339

   > @handreyrc Awesome! Thank you very much!!
   > 
   > I didn't have time to do a thorough review yet, but I looked at the 
Storybook (thanks for making it so easy to review it!)
   > 
   > 1. Dev webapp is allowing nodes to be moved. Is that intentional?
   > 2. Error edges seem to be broken?
   > 
   > * <img alt="image" width="1103" height="581" 
src="https://private-user-images.githubusercontent.com/1584568/518367368-4f8fd72c-b4a0-4710-bfca-9efe8b596bbc.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NjQwNDE1MDMsIm5iZiI6MTc2NDA0MTIwMywicGF0aCI6Ii8xNTg0NTY4LzUxODM2NzM2OC00ZjhmZDcyYy1iNGEwLTQ3MTAtYmZjYS05ZWZlOGI1OTZiYmMucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MTEyNSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTExMjVUMDMyNjQzWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9OGI2N2Y4Y2IwZjE4NjNiZmFmMjlhMTYyNGI0YTFkYmU0ZDFjNzZkODBmZTJmZGIzNjRlMzFmMTc5YTRkYzkzYyZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.SrcS7Ouj3pESEMRKLNabSDjvKd_IJoHlu2_yrNfbP0g";>
   > 
   > 3. The "Empty" case doesn't seem to be empty? 😅
   > 
   > * <img alt="image" width="1103" height="595" 
src="https://private-user-images.githubusercontent.com/1584568/518367637-a11b7357-33c0-4866-bf31-c72d44f8b03a.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NjQwNDE1MDMsIm5iZiI6MTc2NDA0MTIwMywicGF0aCI6Ii8xNTg0NTY4LzUxODM2NzYzNy1hMTFiNzM1Ny0zM2MwLTQ4NjYtYmYzMS1jNzJkNDRmOGIwM2EucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MTEyNSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTExMjVUMDMyNjQzWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9MjljNGY3MDU1ZGQyNGQ5ZWQwNTc5MTNjMjVjZWJhMDVkZmRlODcwZjU0YTVkNWQ5NjllMWJmNjk5NTI5OTE1OSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.zoq2HoVOsVjGn8RCpNlO3Hp1YqChRgDJoU_41kD_21A";>
   
   Hey @tiagobento ,
   
   1) it's intentional, it should be possible to move nodes in the dev session. 
   2) Error edges are not broken, we can handle workflow exceptions by using 
compesation transitions / edges. Those examples come from our webtools 
[kubesmarts](https://start.kubesmarts.org/#/sample-catalog). Anyway I renamed 
that workflow and created a new one with actual error transitions to make it 
easy to grasp.
   3) Good catch, it is fixed!
   
   Thanks a lot for rechecking my work!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to