gabriel-farache commented on PR #4094: URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/4094#issuecomment-3660054919
@wmedvede <img width="540" height="112" alt="image" src="https://github.com/user-attachments/assets/399ecca1-b459-4baa-800b-9b5ffdd3f9da"; /> <img width="758" height="366" alt="image" src="https://github.com/user-attachments/assets/101f26e8-2ccd-4d0c-b329-09aae0f08df4"; /> See above that for 1 trace there are 4 spans so that's OK. But we should have more than that. The wrong amount of spans created is due to filtering of the internal nodes https://github.com/apache/incubator-kie-kogito-runtimes/pull/4094/files#diff-eb172ba601dbf0e7569152677c85d44d34427d18239c103808ca20a6b50f59c0R138-R142 to avoid "noises" and onyl having "real" nodes, but I see now that this will cause confusion and introduce inconsistency, I'll remove this filtering and deal in absolute here. Take a look again because it seems very very verbose now, even the script/function execution have their own span, maybe I should at least exclude those one? Or let it be configurable in the properties? For the `node.completed`, I fixed it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
