Copilot commented on code in PR #6569:
URL:
https://github.com/apache/incubator-kie-drools/pull/6569#discussion_r2734914332
##########
drools-test-coverage/test-compiler-integration/src/test/java/org/drools/mvel/integrationtests/SwitchOverStringTest.java:
##########
@@ -59,16 +59,9 @@ public void cleanUp() {
@ParameterizedTest(name = "KieBase type={0}")
@MethodSource("parameters")
public void
testCompileSwitchOverStringWithLngLevel17(KieBaseTestConfiguration
kieBaseTestConfiguration) {
- double javaVersion =
Double.valueOf(System.getProperty("java.specification.version"));
- Assumptions.assumeTrue(javaVersion >= 1.7, "Test only makes sense on
Java 7+.");
- System.setProperty("drools.dialect.java.compiler.lnglevel", "1.7");
- try {
- KieBuilder kieBuilder =
KieUtil.getKieBuilderFromDrls(kieBaseTestConfiguration, false,
FUNCTION_WITH_SWITCH_OVER_STRING);
- List<Message> errors =
kieBuilder.getResults().getMessages(Message.Level.ERROR);
- assertThat(errors.isEmpty()).as(errors.toString()).isTrue();
- } finally {
- System.clearProperty("drools.dialect.java.compiler.lnglevel");
- }
+ KieBuilder kieBuilder =
KieUtil.getKieBuilderFromDrls(kieBaseTestConfiguration, false,
FUNCTION_WITH_SWITCH_OVER_STRING);
+ List<Message> errors =
kieBuilder.getResults().getMessages(Message.Level.ERROR);
+ assertThat(errors.isEmpty()).as(errors.toString()).isTrue();
Review Comment:
The implementation of `testCompileSwitchOverStringWithLngLevel17` no longer
sets `drools.dialect.java.compiler.lnglevel` explicitly and instead relies on
the default language level (derived from the running JDK), so the method name
suggesting a specific `lnglevel` of 17 is now misleading; consider renaming the
test (or reintroducing an explicit level setting) so that the name accurately
reflects what is being exercised.
```suggestion
System.setProperty("drools.dialect.java.compiler.lnglevel", "17");
try {
KieBuilder kieBuilder =
KieUtil.getKieBuilderFromDrls(kieBaseTestConfiguration, false,
FUNCTION_WITH_SWITCH_OVER_STRING);
List<Message> errors =
kieBuilder.getResults().getMessages(Message.Level.ERROR);
assertThat(errors.isEmpty()).as(errors.toString()).isTrue();
} finally {
System.clearProperty("drools.dialect.java.compiler.lnglevel");
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
