tkobayas commented on code in PR #6569:
URL:
https://github.com/apache/incubator-kie-drools/pull/6569#discussion_r2734998157
##########
drools-test-coverage/test-compiler-integration/src/test/java/org/drools/mvel/integrationtests/SwitchOverStringTest.java:
##########
@@ -70,18 +69,4 @@ public void
testCompileSwitchOverStringWithLngLevel17(KieBaseTestConfiguration k
System.clearProperty("drools.dialect.java.compiler.lnglevel");
}
}
-
- @ParameterizedTest(name = "KieBase type={0}")
- @MethodSource("parameters")
- public void
testShouldFailToCompileSwitchOverStringWithLngLevel16(KieBaseTestConfiguration
kieBaseTestConfiguration) {
- System.setProperty("drools.dialect.java.compiler.lnglevel", "1.6");
- try {
- KieBuilder kieBuilder =
KieUtil.getKieBuilderFromDrls(kieBaseTestConfiguration, false,
FUNCTION_WITH_SWITCH_OVER_STRING);
- List<Message> errors =
kieBuilder.getResults().getMessages(Message.Level.ERROR);
- assertThat(errors.isEmpty()).as("Should have an error").isFalse();
-
- } finally {
- System.clearProperty("drools.dialect.java.compiler.lnglevel");
- }
- }
Review Comment:
remove the test because drools runs on java 17 or higher, so java version
1.6 test is no longer required,
##########
drools-test-coverage/test-compiler-integration/src/test/java/org/drools/mvel/integrationtests/SwitchOverStringTest.java:
##########
@@ -70,18 +69,4 @@ public void
testCompileSwitchOverStringWithLngLevel17(KieBaseTestConfiguration k
System.clearProperty("drools.dialect.java.compiler.lnglevel");
}
}
-
- @ParameterizedTest(name = "KieBase type={0}")
- @MethodSource("parameters")
- public void
testShouldFailToCompileSwitchOverStringWithLngLevel16(KieBaseTestConfiguration
kieBaseTestConfiguration) {
- System.setProperty("drools.dialect.java.compiler.lnglevel", "1.6");
- try {
- KieBuilder kieBuilder =
KieUtil.getKieBuilderFromDrls(kieBaseTestConfiguration, false,
FUNCTION_WITH_SWITCH_OVER_STRING);
- List<Message> errors =
kieBuilder.getResults().getMessages(Message.Level.ERROR);
- assertThat(errors.isEmpty()).as("Should have an error").isFalse();
-
- } finally {
- System.clearProperty("drools.dialect.java.compiler.lnglevel");
- }
- }
Review Comment:
removed the test because drools runs on java 17 or higher, so java version
1.6 test is no longer required,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
