thiagoelg commented on code in PR #3403:
URL:
https://github.com/apache/incubator-kie-tools/pull/3403#discussion_r2746682398
##########
packages/k8s-yaml-to-apiserver-requests/src/patchK8sResourceYaml.ts:
##########
@@ -17,23 +17,15 @@
* under the License.
*/
-import { Operation, TestOperation, applyPatch, getValueByPointer } from
"fast-json-patch";
+import { Operation, TestOperation, applyPatch } from "fast-json-patch";
Review Comment:
Does the `jsonpath-rfc9535` library offer similar types so that we can
remove this dependency?
##########
packages/k8s-yaml-to-apiserver-requests/src/patchK8sResourceYaml.ts:
##########
@@ -81,14 +47,6 @@ export function patchK8sResourceYaml(k8sResourceYaml:
string, patches: ResourceP
: applyPatch(updatedResource, patch.testFilters, false,
false).every(({ test }) => Boolean(test));
Review Comment:
We should be using the `exec` method from the `jsonpath-rfc9535` library
here, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
