Adarshvk98 commented on code in PR #3403:
URL:
https://github.com/apache/incubator-kie-tools/pull/3403#discussion_r2747229080
##########
packages/k8s-yaml-to-apiserver-requests/src/patchK8sResourceYaml.ts:
##########
@@ -81,14 +47,6 @@ export function patchK8sResourceYaml(k8sResourceYaml:
string, patches: ResourceP
: applyPatch(updatedResource, patch.testFilters, false,
false).every(({ test }) => Boolean(test));
Review Comment:
From what I understand, No, we shouldn't use jsonpath-rfc9535 here. this
library is for JSONPath queries (used for token interpolation), while here uses
JSON Patch (RFC 6902) operations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
