martinweiler commented on code in PR #2301:
URL: 
https://github.com/apache/incubator-kie-kogito-apps/pull/2301#discussion_r2789648870


##########
jobs/jobs-common-embedded/src/main/java/org/kie/kogito/app/jobs/impl/VertxJobScheduler.java:
##########
@@ -597,6 +615,7 @@ private JobDetails computeNextJobDetailsIfAny(JobDetails 
jobDetails) {
                     .status(JobStatus.SCHEDULED)
                     .retries(0)
                     
.executionTimeout(jobDetails.getTrigger().hasNextFireTime().getTime())
+                    .exceptionDetails(null) // Clear exception details on 
successful execution

Review Comment:
   I don't see this working as expected. Although the final execution of the 
job is successful, the exception details are still there:
   ```
         {
           "id": "d69f5689-436c-4009-8342-85516b792c4b",
           "processId": "HelloWorld",
           "rootProcessId": null,
           "processInstanceId": "bcc0c12e-6082-4dce-ad74-a0ab96c6e575",
           "status": "EXECUTED",
           "expirationTime": "2026-02-10T18:34:33.913Z",
           "nodeInstanceId": "e41cd14b-cf24-4cc5-822e-141c7582dc27",
           "exceptionMessage": 
"org.kie.kogito.process.ProcessInstanceExecutionException",
           "exceptionDetails": "Process instance with id 
bcc0c12e-6082-4dce-ad74-a0ab96c6e575 failed because of 
[HelloWorld:bcc0c12e-6082-4dce-ad74-a0ab96c6e575 - Dummy Service 
Task:[uuid=_5E115E1B-9B42-40CB-A924-3F75A568B0F0]] -- EXCEPTION NUMBER 2",
           "retries": 2
         }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to