jstastny-cz commented on code in PR #2301: URL: https://github.com/apache/incubator-kie-kogito-apps/pull/2301#discussion_r2791807037
########## jobs/jobs-common-embedded/src/main/java/org/kie/kogito/app/jobs/integrations/DefaultJobExceptionDetailsExtractor.java: ########## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.kie.kogito.app.jobs.integrations; + +import org.kie.kogito.jobs.service.model.JobExecutionExceptionDetails; + +/** + * Default implementation of JobExceptionDetailsExtractor. + * Extracts the exception class name and message without any sanitization. + */ +public class DefaultJobExceptionDetailsExtractor implements JobExceptionDetailsExtractor { + + @Override + public JobExecutionExceptionDetails extractExceptionDetails(Exception exception) { + if (exception != null) { + String exceptionMessage = exception.getClass().getName(); + String exceptionDetails = exception.getMessage(); Review Comment: Right, or remove the limit completely. I am thinking if based on the fact that we allow users to provide their own implementation of extractor interface - the contents put into the fields might vary - e.g. someone picks to put whole stacktrace into exceptionDetails or so. Here I would appreciate your opinion which direction to take, if we set limits (and if these are reasonable) and validate the lenght (or trim), or if we rely on each DB type limits. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
