baldimir commented on code in PR #4178: URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/4178#discussion_r2799504895
########## quarkus/addons/asyncapi/deployment/src/main/java/org/kie/kogito/quarkus/serverless/workflow/asyncapi/AsyncAPIInfoConverter.java: ########## @@ -27,9 +27,11 @@ import org.kie.kogito.serverless.workflow.asyncapi.AsyncInfo; import org.kie.kogito.serverless.workflow.asyncapi.AsyncInfoConverter; -import com.asyncapi.v2._6_0.model.AsyncAPI; -import com.asyncapi.v2._6_0.model.channel.ChannelItem; -import com.asyncapi.v2._6_0.model.channel.operation.Operation; +// Updated to AsyncAPI v3.0.0 (from v2.0.0) as part of Quarkus 3.27.2 upgrade Review Comment: I see a lot of similar comments on multiple places. Those are nice for the reviewers, however when written in the code, they may stay there forever. Please consider removing them and instead writing comments in the PRs to the actual lines. E.g. in a year no one would probably care that it was updated part of the Quarkus upgrade. And if yes, people can find it in git history. What do you think, please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
