baldimir commented on code in PR #4178:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4178#discussion_r2799517525
##########
quarkus/addons/asyncapi/deployment/src/main/java/org/kie/kogito/quarkus/serverless/workflow/asyncapi/AsyncAPIInfoConverter.java:
##########
@@ -47,20 +49,47 @@ public Optional<AsyncInfo> apply(String id) {
}
private static AsyncInfo from(AsyncAPI asyncApi) {
- Map<String, AsyncChannelInfo> map = new HashMap<>();
- for (Entry<String, ChannelItem> entry :
asyncApi.getChannels().entrySet()) {
- addChannel(map, entry.getValue().getPublish(), entry.getKey() +
"_out", true);
- addChannel(map, entry.getValue().getSubscribe(), entry.getKey(),
false);
+ Map<String, String> channelIdToAddress =
buildChannelAddressMap(asyncApi);
+ Map<String, AsyncChannelInfo> channelInfoByOperationId =
buildOperationChannelInfoMap(asyncApi, channelIdToAddress);
+ return new AsyncInfo(channelInfoByOperationId);
+ }
+
+ // AsyncAPI v3.0.0: channels are separate top-level objects with addresses
Review Comment:
If you want to document what a method does, please use standard JavaDoc
comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
