jstastny-cz commented on code in PR #2301:
URL:
https://github.com/apache/incubator-kie-kogito-apps/pull/2301#discussion_r2811827531
##########
jobs/jobs-common-embedded/src/main/java/org/kie/kogito/app/jobs/impl/VertxJobScheduler.java:
##########
@@ -370,7 +456,7 @@ public void cancel(String jobId) {
JobDetails jobDetails = jobStore.find(jobContext, jobId);
Review Comment:
Previously the cancel operation was not performing store operations at all -
it just removed the timer at given moment (I considered it a bug). Now I think
we might need to get back to what `cancel` in the scheduler context should
really mean.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
