martinweiler commented on code in PR #2301:
URL: 
https://github.com/apache/incubator-kie-kogito-apps/pull/2301#discussion_r2819915133


##########
jobs/jobs-common-embedded/src/main/java/org/kie/kogito/app/jobs/impl/VertxJobScheduler.java:
##########
@@ -370,7 +456,7 @@ public void cancel(String jobId) {
         JobDetails jobDetails = jobStore.find(jobContext, jobId);

Review Comment:
   Did you just invent a new word - `upsert` (TM)? I like it :)
   
   Ok, I understand your point regarding the periodic timers. Let's leave this 
logic for now and if needed, we can find a solution that fits all use cases 
later.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to