pefernan commented on code in PR #4178:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4178#discussion_r2821266832
##########
quarkus/addons/knative/eventing/deployment/src/main/java/org/kie/kogito/addons/quarkus/knative/eventing/deployment/SinkConfiguration.java:
##########
@@ -20,10 +20,13 @@
import java.util.Optional;
-import io.quarkus.runtime.annotations.ConfigGroup;
import io.smallrye.config.WithDefault;
-@ConfigGroup
+/**
+ * Nested configuration group for Knative Sink settings.
Review Comment:
Same
##########
quarkus/addons/flyway/runtime/src/main/java/org/kie/flyway/quarkus/KieQuarkusFlywayNamedModuleConfig.java:
##########
@@ -19,10 +19,13 @@
package org.kie.flyway.quarkus;
-import io.quarkus.runtime.annotations.ConfigGroup;
import io.smallrye.config.WithDefault;
-@ConfigGroup
+/**
Review Comment:
I'd cleanup this comment
##########
quarkus/extensions/kogito-quarkus-serverless-workflow-extension/kogito-quarkus-serverless-workflow-extension-live-reload-test/src/test/java/org/kie/kogito/quarkus/serverless/workflow/deployment/livereload/LiveReloadProcessorTest.java:
##########
@@ -180,6 +187,9 @@ void testAsyncApi() throws IOException {
test.addResourceFile("asyncPublisher.sw.json", new
String(Objects.requireNonNull(inputStream).readAllBytes()));
}
+ // Add a small delay to allow Quarkus to complete the hot reload
+ Thread.sleep(500);
Review Comment:
I'd use `awaitility` instead of Thread.sleep if possible. There are multiple
examples in the codebase
([ej](https://github.com/apache/incubator-kie-kogito-runtimes/blob/baea286b65db29e3cf7ca781375a784c9a6c3ee8/quarkus/addons/opentelemetry/integration-tests/src/test/java/org/kie/kogito/quarkus/serverless/workflow/opentelemetry/OpenTelemetryRestartIT.java#L207):
https://github.com/apache/incubator-kie-kogito-runtimes/blob/baea286b65db29e3cf7ca781375a784c9a6c3ee8/quarkus/addons/opentelemetry/integration-tests/src/test/java/org/kie/kogito/quarkus/serverless/workflow/opentelemetry/OpenTelemetryRestartIT.java#L207
)
##########
quarkus/addons/rest-exception-handler/pom.xml:
##########
@@ -79,7 +79,7 @@
<groupId>jakarta.xml.bind</groupId>
<artifactId>jakarta.xml.bind-api</artifactId>
<scope>test</scope>
- <version>4.0.1</version>
+ <version>4.0.4</version>
Review Comment:
same as before
##########
quarkus/extensions/kogito-quarkus-workflow-extension-common/kogito-quarkus-workflow-common/src/main/java/org/kie/kogito/quarkus/workflow/config/KogitoPersistenceBuildTimeConfig.java:
##########
@@ -18,11 +18,14 @@
*/
package org.kie.kogito.quarkus.workflow.config;
-import io.quarkus.runtime.annotations.ConfigGroup;
import io.smallrye.config.WithDefault;
import io.smallrye.config.WithName;
-@ConfigGroup
+/**
+ * Nested configuration group for persistence build-time settings.
Review Comment:
Comment
##########
quarkus/addons/process-management/runtime/pom.xml:
##########
@@ -88,7 +88,7 @@
<groupId>jakarta.xml.bind</groupId>
<artifactId>jakarta.xml.bind-api</artifactId>
<scope>test</scope>
- <version>4.0.1</version>
+ <version>4.0.4</version>
Review Comment:
Can we use a property for this version?
Looking at Quarkus bom they still use `4.0.2` can we align to that version?
https://github.com/quarkusio/quarkus/blob/3.27/bom/application/pom.xml#L82
##########
quarkus/extensions/kogito-quarkus-serverless-workflow-extension/kogito-quarkus-serverless-workflow/src/main/java/org/kie/kogito/quarkus/serverless/workflow/config/KogitoServerlessWorkflowBuildTimeConfig.java:
##########
@@ -18,11 +18,14 @@
*/
package org.kie.kogito.quarkus.serverless.workflow.config;
-import io.quarkus.runtime.annotations.ConfigGroup;
import io.smallrye.config.WithDefault;
import io.smallrye.config.WithName;
-@ConfigGroup
+/**
+ * Nested configuration group for serverless workflow build-time settings.
Review Comment:
Comment
##########
quarkus/addons/tracing-decision/deployment/src/main/java/org/kie/kogito/tracing/decision/quarkus/deployment/KogitoDevServicesBuildTimeConfig.java:
##########
@@ -20,32 +20,33 @@
import java.util.Optional;
-import io.quarkus.runtime.annotations.ConfigGroup;
-import io.quarkus.runtime.annotations.ConfigItem;
+import io.smallrye.config.WithDefault;
-@ConfigGroup
-public class KogitoDevServicesBuildTimeConfig {
+/**
+ * Nested configuration group for Kogito Trusty Service DevServices build-time
settings.
Review Comment:
Maybe we don't need this too
##########
quarkus/extensions/kogito-quarkus-extension-common/kogito-quarkus-common/src/main/java/org/kie/kogito/quarkus/config/KogitoEventingRuntimeConfig.java:
##########
@@ -18,11 +18,14 @@
*/
package org.kie.kogito.quarkus.config;
-import io.quarkus.runtime.annotations.ConfigGroup;
import io.smallrye.config.WithDefault;
import io.smallrye.config.WithName;
-@ConfigGroup
+/**
+ * Nested configuration group for eventing runtime settings.
Review Comment:
Comment
##########
quarkus/extensions/kogito-quarkus-workflow-extension-common/kogito-quarkus-workflow-common-deployment/src/main/java/org/kie/kogito/quarkus/workflow/deployment/config/KogitoDevServicesBuildTimeConfig.java:
##########
@@ -20,10 +20,13 @@
import java.util.Optional;
-import io.quarkus.runtime.annotations.ConfigGroup;
import io.smallrye.config.WithDefault;
-@ConfigGroup
+/**
+ * Nested configuration group for Kogito DevServices build-time settings.
Review Comment:
Comment
##########
quarkus/extensions/kogito-quarkus-workflow-extension-common/kogito-quarkus-workflow-common/src/main/java/org/kie/kogito/quarkus/workflow/config/KogitoPersistenceRuntimeConfig.java:
##########
@@ -20,11 +20,14 @@
import java.util.Optional;
-import io.quarkus.runtime.annotations.ConfigGroup;
import io.smallrye.config.WithDefault;
import io.smallrye.config.WithName;
-@ConfigGroup
+/**
+ * Nested configuration group for persistence runtime settings.
Review Comment:
Comment
##########
quarkus/extensions/kogito-quarkus-extension-common/kogito-quarkus-common/src/main/java/org/kie/kogito/quarkus/config/KogitoAuthRuntimeConfig.java:
##########
@@ -21,11 +21,14 @@
import java.util.Optional;
-import io.quarkus.runtime.annotations.ConfigGroup;
import io.smallrye.config.WithDefault;
import io.smallrye.config.WithName;
-@ConfigGroup
+/**
+ * Nested configuration group for authentication runtime settings.
Review Comment:
Comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
