yesamer commented on code in PR #6614: URL: https://github.com/apache/incubator-kie-drools/pull/6614#discussion_r2888982896
########## kie-dmn/kie-dmn-feel/src/main/java/org/kie/dmn/feel/runtime/custom/CustomZonedDateTime.java: ########## @@ -0,0 +1,193 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.kie.dmn.feel.runtime.custom; + +import org.kie.dmn.feel.runtime.functions.DateAndTimeFunction; + +import java.io.Serializable; +import java.time.LocalDate; +import java.time.LocalTime; +import java.time.ZoneId; +import java.time.ZoneOffset; +import java.time.ZonedDateTime; +import java.time.chrono.ChronoLocalDateTime; +import java.time.chrono.ChronoZonedDateTime; +import java.time.format.DateTimeFormatter; +import java.time.temporal.Temporal; +import java.time.temporal.TemporalAccessor; +import java.time.temporal.TemporalAmount; +import java.time.temporal.TemporalField; +import java.time.temporal.TemporalUnit; +import java.util.Objects; + +/** + * This class is meant as sort-of <b>decorator</b> over <code>ZonedDateTime</code>, that is a final class. + * It is used to provide a string representation that preserves seconds even when they are zero, + */ +public final class CustomZonedDateTime + implements Temporal, ChronoZonedDateTime<LocalDate>, Serializable { + + private final ZonedDateTime zonedDateTime; + private final String stringRepresentation; + + private CustomZonedDateTime(ZonedDateTime zonedDateTime) { + this.zonedDateTime = zonedDateTime; + ZoneId zone = zonedDateTime.getZone(); + if (zone instanceof ZoneOffset) { + // For ZoneOffset, use ISO format (e.g., 2021-01-01T10:10:10+11:00) + this.stringRepresentation = zonedDateTime.format(DateTimeFormatter.ISO_OFFSET_DATE_TIME); + } else { + // For ZoneRegion, use REGION_DATETIME_FORMATTER which properly handles extended years + this.stringRepresentation = zonedDateTime.format(DateAndTimeFunction.REGION_DATETIME_FORMATTER); + } + } + + public static CustomZonedDateTime of(LocalDate date, LocalTime time, ZoneId zone) { + return new CustomZonedDateTime(ZonedDateTime.of(date, time, zone)); + } + + public static CustomZonedDateTime from(TemporalAccessor temporal) { + return new CustomZonedDateTime(ZonedDateTime.from(temporal)); + } + + public static CustomZonedDateTime of(int coercedYear, int coercedMonth, int coercedDay, int coercedHour, int coercedMinute, int coercedSecond, int i, ZoneId zoneId) { + return new CustomZonedDateTime(ZonedDateTime.of(coercedYear, coercedMonth, coercedDay, coercedHour, coercedMinute, coercedSecond, i, zoneId)); Review Comment: @AthiraHari77 if the original class manages that as `i`, please ignore this. I think we should keep 1:1 copy where the behavior doesn't change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
