gitgabrio commented on code in PR #6614: URL: https://github.com/apache/incubator-kie-drools/pull/6614#discussion_r2889143629
########## kie-dmn/kie-dmn-feel/src/main/java/org/kie/dmn/feel/runtime/custom/CustomZonedDateTime.java: ########## @@ -0,0 +1,193 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.kie.dmn.feel.runtime.custom; + +import org.kie.dmn.feel.runtime.functions.DateAndTimeFunction; + +import java.io.Serializable; +import java.time.LocalDate; +import java.time.LocalTime; +import java.time.ZoneId; +import java.time.ZoneOffset; +import java.time.ZonedDateTime; +import java.time.chrono.ChronoLocalDateTime; +import java.time.chrono.ChronoZonedDateTime; +import java.time.format.DateTimeFormatter; +import java.time.temporal.Temporal; +import java.time.temporal.TemporalAccessor; +import java.time.temporal.TemporalAmount; +import java.time.temporal.TemporalField; +import java.time.temporal.TemporalUnit; +import java.util.Objects; + +/** + * This class is meant as sort-of <b>decorator</b> over <code>ZonedDateTime</code>, that is a final class. + * It is used to provide a string representation that preserves seconds even when they are zero, + */ +public final class CustomZonedDateTime Review Comment: TBH not sure to follow: why it should be "Iso" ? This class is exactly a "Custom" version of the (wrapped) ZonedDateTime to "override" the toString method 🤔 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
