rajalakshmys-27 commented on code in PR #3556:
URL:
https://github.com/apache/incubator-kie-tools/pull/3556#discussion_r3189900888
##########
packages/bpmn-editor/package.json:
##########
@@ -16,9 +16,13 @@
"start": "run-script-os",
"start:linux:darwin": "cross-env STORYBOOK_PORT=$(build-env
bpmnEditor.storybook.port) pnpm exec kie-tools--storybook --storybookArgs=\"dev
--no-open\"",
"start:win32": "pnpm powershell \"cross-env STORYBOOK_PORT=$(build-env
bpmnEditor.storybook.port) pnpm exec kie-tools--storybook --storybookArgs='dev
--no-open'",
- "test-e2e": "run-script-if --ignore-errors \"$(build-env
endToEndTests.ignoreFailures)\" --bool \"$(build-env endToEndTests.run)\"
--then \"rimraf ./dist-tests-e2e\" \"pnpm test-e2e:run\"",
+ "test-e2e": "run-script-if --ignore-errors \"$(build-env
endToEndTests.ignoreFailures)\" --bool \"$(build-env endToEndTests.run)\"
--then \"pnpm test-e2e:condition\"",
+ "test-e2e:condition": "run-script-if --bool \"$(build-env
endToEndTests.containerized)\" --then \"pnpm rimraf ./dist-tests-e2e\" \"pnpm
test-e2e:container:run\" --else \"pnpm rimraf ./dist-tests-e2e\" \"pnpm
test-e2e:run\"",
+ "test-e2e:container:clean": "playwright-base-container clean",
+ "test-e2e:container:run": "start-server-and-test 'pnpm start'
http://localhost:$(build-env bpmnEditor.storybook.port)/iframe.html
\"playwright-base-container run
--additional-env=KIE_TOOLS_PLAYWRIGHT_CONTAINER__PORT=$(build-env
bpmnEditor.storybook.port)
--container-workdir=incubator-kie-tools/packages/bpmn-editor
--container-name=kie-tools-playwright-containerization-bpmn-editor -- $@\"",
+ "test-e2e:container:shell": "start-server-and-test 'pnpm start'
http://localhost:$(build-env bpmnEditor.storybook.port)/iframe.html
'playwright-base-container shell
--additional-env=KIE_TOOLS_PLAYWRIGHT_CONTAINER__PORT=$(build-env
bpmnEditor.storybook.port)
--container-workdir=incubator-kie-tools/packages/bpmn-editor
--container-name=kie-tools-playwright-containerization-bpmn-editor'",
"test-e2e:open": "pnpm exec playwright show-report dist-tests-e2e/reports",
- "test-e2e:run": "pnpm exec playwright test --pass-with-no-tests"
+ "test-e2e:run": "pnpm exec playwright test --update-snapshots"
Review Comment:
thanks for pointing that out! I forgot to remove that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
