jomarko commented on code in PR #3556:
URL: 
https://github.com/apache/incubator-kie-tools/pull/3556#discussion_r3193255671


##########
packages/bpmn-editor/tests-e2e/__screenshots__/chromium/propertiesPanel/task-multi-instance-parallel.png:
##########


Review Comment:
   I have commented on this also in my previous review round. My point is the 
current screenshot show:
   - user typed and expression in format `${variableName}`
   - editor say there is no match in available variables
   
   While I understand, what editor says is correct, variable with such name 
doesn't exist, as user, the UI flash box text **No matches** indicates to me 
some problem and some doubts, if my operation was saved or if it is valid.
   
   Could we somehow clarify if the current editor behavior is by design and is 
intended to work in this way? I think on other places in the editor we display 
flash message to **Create expression** if a new value is spot and is not 
available in existing.



##########
packages/bpmn-editor/tests-e2e/__screenshots__/chromium/propertiesPanel/task-multi-instance-sequential.png:
##########


Review Comment:
   same question as above



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to