yesamer commented on code in PR #4270:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4270#discussion_r3225772655
##########
kogito-build/kogito-dependencies-bom/pom.xml:
##########
@@ -137,12 +140,14 @@
<version.org.assertj>3.27.7</version.org.assertj>
<version.org.glassfish.jaxb>4.0.6</version.org.glassfish.jaxb>
<version.org.json-unit-assertj>2.9.0</version.org.json-unit-assertj>
- <version.org.hamcrest>2.2</version.org.hamcrest> <!-- else old version
coming from Mockito wins and breaks tests -->
+ <version.org.hamcrest>3.0</version.org.hamcrest> <!-- else old version
coming from Mockito wins and breaks tests -->
<version.org.junit>4.13.2</version.org.junit>
- <version.org.junit.jupiter>5.13.4</version.org.junit.jupiter>
- <version.org.junit.platform>1.13.4</version.org.junit.platform><!--
otherwise Quarkus brings its own, silently disabling some tests -->
+ <version.org.junit.jupiter>6.0.3</version.org.junit.jupiter>
+ <version.org.junit.platform>6.0.3</version.org.junit.platform><!-- JUnit 6
unified versioning: platform shares the jupiter version (junit-bom 6.0.3);
otherwise Quarkus brings its own, silently disabling some tests -->
Review Comment:
@nrknithin As suggested in drools repo, I suggest merging junit jupiter and
platform version management.
##########
kogito-build/kogito-dependencies-bom/pom.xml:
##########
@@ -89,10 +91,11 @@
Kubernetes addons since they use a different version.
-->
<version.io.fabric8.kubernetes-client>7.3.1</version.io.fabric8.kubernetes-client>
- <version.io.micrometer>1.14.12</version.io.micrometer>
+ <version.io.micrometer>1.16.4</version.io.micrometer>
<version.org.flywaydb>11.14.1</version.org.flywaydb>
<version.org.postgresql>42.7.11</version.org.postgresql>
- <version.com.h2>2.3.232</version.com.h2> <!-- Overriding version 2.3.230
to fix https://github.com/h2database/h2database/issues/4079 -->
+ <version.com.h2>2.4.240</version.com.h2> <!-- Overriding version 2.3.230
to fix https://github.com/h2database/h2database/issues/4079 -->
+ <version.io.serverlessworkflow>4.1.0.Final</version.io.serverlessworkflow>
Review Comment:
@nrknithin Why this is required?
##########
kogito-build/kogito-dependencies-bom/pom.xml:
##########
@@ -89,10 +91,11 @@
Kubernetes addons since they use a different version.
-->
<version.io.fabric8.kubernetes-client>7.3.1</version.io.fabric8.kubernetes-client>
- <version.io.micrometer>1.14.12</version.io.micrometer>
+ <version.io.micrometer>1.16.4</version.io.micrometer>
<version.org.flywaydb>11.14.1</version.org.flywaydb>
<version.org.postgresql>42.7.11</version.org.postgresql>
- <version.com.h2>2.3.232</version.com.h2> <!-- Overriding version 2.3.230
to fix https://github.com/h2database/h2database/issues/4079 -->
+ <version.com.h2>2.4.240</version.com.h2> <!-- Overriding version 2.3.230
to fix https://github.com/h2database/h2database/issues/4079 -->
Review Comment:
@nrknithin Not related to your changes, but I guess we can remove that stale
comment, WDTY?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
