jomarko commented on code in PR #3565:
URL:
https://github.com/apache/incubator-kie-tools/pull/3565#discussion_r3256966747
##########
packages/online-editor/src/dmnRunner/DmnRunnerDrawer.tsx:
##########
@@ -37,9 +37,13 @@ export function DmnRunnerDrawer(props:
React.PropsWithChildren<{}>) {
!dmnRunnerState.isExpanded ?
"kogito--editor__drawer-content-onClose" : "kogito--editor__drawer-content-open"
}
panelContent={
- <DmnRunnerErrorBoundary>
- <DmnRunnerDrawerPanelContent />
- </DmnRunnerErrorBoundary>
+ props.isDmnEditor ? (
+ <DmnRunnerErrorBoundary>
+ <DmnRunnerDrawerPanelContent />
+ </DmnRunnerErrorBoundary>
+ ) : (
+ <></>
Review Comment:
could you please explain why are changes in this file needed?
`isDmnEditor` seems to be unused.
Generally, as it is placed in `dmnRunner` specific package, I expect it is
by definition always true
Isn't this only some leftover form the fix implementation?
##########
packages/bpmn-editor/src/diagram/BpmnPalette.css:
##########
@@ -92,3 +158,32 @@
.kie-bpmn-editor--variables-panel-toggle-button.active {
color: #006ba4;
}
+
+.kie-bpmn-editor--ellipsis-button {
Review Comment:
minor comment, but this class mixes two naming patterns:
- `kie-bpmn-editor--palette-[classname]`
- `kie-bpmn-editor--[classname]`
As the fix is related to pallete, shouldn't all added css classes use the:
- `kie-bpmn-editor--palette-[classname]` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
