thiagoelg commented on code in PR #3565:
URL:
https://github.com/apache/incubator-kie-tools/pull/3565#discussion_r3261700472
##########
packages/online-editor/src/dmnRunner/DmnRunnerDrawer.tsx:
##########
@@ -37,9 +37,13 @@ export function DmnRunnerDrawer(props:
React.PropsWithChildren<{}>) {
!dmnRunnerState.isExpanded ?
"kogito--editor__drawer-content-onClose" : "kogito--editor__drawer-content-open"
}
panelContent={
- <DmnRunnerErrorBoundary>
- <DmnRunnerDrawerPanelContent />
- </DmnRunnerErrorBoundary>
+ props.isDmnEditor ? (
+ <DmnRunnerErrorBoundary>
+ <DmnRunnerDrawerPanelContent />
+ </DmnRunnerErrorBoundary>
+ ) : (
+ <></>
Review Comment:
This is related to this issue:
https://github.com/apache/incubator-kie-tools/pull/3565#discussion_r3202545410
For some reason, the DMN Runner drawer was being rendered (but hidden) even
when the BPMN Editor was active. This was causing the "gray bar" to appear in
screenshots when running Playwright tests (I was able to reproduce it in `main`
as well).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
