Copilot commented on code in PR #6833:
URL: https://github.com/apache/incubator-kie/pull/6833#discussion_r3819863568
##########
kogito-jbpm/jbpm-flow/src/main/java/org/jbpm/workflow/instance/impl/WorkflowProcessInstanceImpl.java:
##########
@@ -595,9 +595,7 @@ public TimerInstance configureSLATimer(String
slaDueDateExpression, String nodeI
}
TimerInstance timerInstance = createDurationTimer(duration);
- if (useTimerSLATracking()) {
- registerTimer(timerInstance, nodeInstanceId);
- }
+ registerTimer(timerInstance, nodeInstanceId);
return timerInstance;
}
Review Comment:
This makes `SLATimerMode=false` ineffective: callers that select external
SLA tracking will now also schedule the internal deadline, so the timer can
mark the SLA violated before an external `slaViolation` signal. Preserve the
conditional timer registration (and migrate the external/no-timer coverage
rather than removing it).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
