Copilot commented on code in PR #7128:
URL: https://github.com/apache/incubator-kie/pull/7128#discussion_r4090983533
##########
kogito-springboot/addons/kubernetes/src/test/resources/application.properties:
##########
@@ -18,4 +18,5 @@
#
spring.main.cloud-platform=KUBERNETES
-spring.cloud.bootstrap.enabled=true
\ No newline at end of file
+spring.cloud.bootstrap.enabled=true
+spring.cloud.kubernetes.discovery.enabled=false
Review Comment:
This new test-only setting is required to prevent Spring Cloud Kubernetes
5.0.2 from connecting to a live cluster during tests, but
`kogito-springboot/addons/kubernetes/README.md` still documents only the two
settings at lines 35-36. Users following that documented test setup can still
hit the same ApplicationContext/401 failure; please add this property to the
test configuration guidance and clarify that it is test-only.
##########
kogito-springboot/bom/pom.xml:
##########
@@ -36,18 +36,18 @@
<allowedPomsList>org.kie.kogito:kogito-spring-boot-bom</allowedPomsList>
<!-- Aligned with Spring Boot Cloud (spring-cloud-kubernetes-fabric8 5.0.1
declares fabric8 7.4.0) -->
Review Comment:
The alignment comment above still says `spring-cloud-kubernetes-fabric8
5.0.1`, but this upgrade moves the Spring Cloud BOM to 2025.1.2, which brings
5.0.2. Leaving the old version here makes the rationale for the Fabric8 pin
inaccurate; please update the comment to match the dependency being managed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
