AnnJoy23 commented on code in PR #7128:
URL: https://github.com/apache/incubator-kie/pull/7128#discussion_r4102274891
##########
kogito-springboot/bom/pom.xml:
##########
@@ -34,20 +34,20 @@
<properties>
<!-- Used to define which poms are allowed to have dependencyManagement
sections. This is to enforce the convention that only the root pom should have
dependencyManagement, and all other poms should inherit from it. -->
<allowedPomsList>org.kie.kogito:kogito-spring-boot-bom</allowedPomsList>
- <!-- Aligned with Spring Boot Cloud (spring-cloud-kubernetes-fabric8 5.0.1
declares fabric8 7.4.0) -->
- <version.io.fabric8>7.4.0</version.io.fabric8>
- <version.io.netty>4.2.17.Final</version.io.netty>
+ <!-- Aligned with Spring Cloud (spring-cloud-kubernetes-fabric8 5.0.2
declares fabric8 7.4.1) -->
Review Comment:
Hi @jomarko ,Thank you for reviewing.
The 5.0.2 version comes from
spring-cloud-dependencies:${version.org.springframework.cloud} . That BOM
declares spring-cloud-kubernetes-fabric8:5.0.2, which in turn requires
io.fabric8:7.4.1. This pin is also overriding the 7.3.1 set in kie-parent to
align with what Spring Cloud Kubernetes actually needs at runtime.
I've expanded the comment to make this traceable and to guide future
maintainers when upgrading version.org.springframework.cloud.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
