Rikkola commented on PR #7160: URL: https://github.com/apache/incubator-kie/pull/7160#issuecomment-6340742129
@tkobayas I went through each item and took actions. Here is a summary. 1. Fixed. DynamicFilter.assertObject() now increments a deliveryEpoch counter before iterating and stamps every newly-registered adapter with that epoch in addSignalAdapter(). 2. Fixed. DSL.not() returns ExprViewItem (not ExistentialExprViewItem). 3. Fixed. LogicGate.activate() now evaluates predicate.test(memory.getLogicGateMemory()[gateIndex], allMatched) — the actual gate memory — instead of the hard-coded 0L. 4. Fixed. LogicGate.clearInputBit() (called by LogicGateOutputSignalProcessor.clearParentBit()) re-evaluates the predicate after clearing the bit (lines 132–143): if the result transitions matched → unmatched it calls clearParentBit on the parent recursively; if it transitions unmatched → matched it calls propagate upward. The reversion therefore cascades through the full ancestor chain 5. Fixed. LogicGate.resetPrior() only clears memory when !statusCanRevert. Gates compiled for reverting children (XOR, XNOR) have statusCanRevert = true, so their parent retains the contribution bits from other inputs across a propagation. Non-reverting gates (AND, OR, NOT) still reset as before. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
