Rikkola commented on PR #7160: URL: https://github.com/apache/incubator-kie/pull/7160#issuecomment-6472132885
Ok. I should have chopped this into even smaller bits. I will keep that in mind with the rest of the work. For @tkobayas 1. I added a blocker that prevents this situation. It is impossible to get working right, but I have another change coming that can cover it. 2. True it is pre-existing. I made a fix, but will make a new PR. 3. I pinned the current behaviour with the test: ``` oneOfUnderOrUnderAndHappyPathExactlyOneAndPositiveFires oneOfUnderOrUnderAndOrderACBDXorOvermatchVetoResets oneOfUnderOrUnderAndOrderCABDXorOvermatchVetoResets oneOfUnderOrUnderAndOrderABCDXorOvermatchBeforeOrSatisfiedVetoResets ``` Nit was actually never reached, so it was removed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
