yesamer commented on code in PR #7283:
URL: https://github.com/apache/incubator-kie/pull/7283#discussion_r4526278564
##########
drools-scenario-simulation/drools-scenario-simulation-backend/src/main/java/org/drools/scenariosimulation/backend/runner/AbstractScenarioRunner.java:
##########
@@ -30,10 +31,6 @@
import
org.drools.scenariosimulation.backend.runner.model.ScenarioResultMetadata;
import org.drools.scenariosimulation.backend.runner.model.ScenarioRunnerDTO;
import org.drools.scenariosimulation.backend.runner.model.ScenarioRunnerData;
-import org.junit.runner.Description;
-import org.junit.runner.Runner;
-import org.junit.runner.notification.Failure;
-import org.junit.runner.notification.RunNotifier;
Review Comment:
@Subhanshu20135 Please revert any change in the old test scenario runner.
Until we keep it, we need to support it without any change. That will require
to have junit 4 as dependency, but it's expected until we don't drop it
completely.
##########
drools-reliability/drools-reliability-core/pom.xml:
##########
@@ -50,23 +50,12 @@
<groupId>org.drools</groupId>
<artifactId>drools-kiesession</artifactId>
</dependency>
-
- <dependency>
- <groupId>junit</groupId>
- <artifactId>junit</artifactId>
- <scope>test</scope>
- </dependency>
- <dependency>
+<dependency>
<groupId>org.assertj</groupId>
<artifactId>assertj-core</artifactId>
<scope>test</scope>
</dependency>
- <dependency>
- <groupId>org.junit.vintage</groupId>
- <artifactId>junit-vintage-engine</artifactId>
- <scope>test</scope>
- </dependency>
- <dependency>
+<dependency>
<groupId>org.junit.jupiter</groupId>
Review Comment:
@Subhanshu20135 Wrong Formatting
##########
drools-reliability/drools-reliability-h2mvstore/pom.xml:
##########
@@ -53,23 +53,12 @@
<artifactId>drools-engine</artifactId>
<scope>test</scope>
</dependency>
-
- <dependency>
- <groupId>junit</groupId>
- <artifactId>junit</artifactId>
- <scope>test</scope>
- </dependency>
- <dependency>
+<dependency>
<groupId>org.assertj</groupId>
<artifactId>assertj-core</artifactId>
<scope>test</scope>
</dependency>
- <dependency>
- <groupId>org.junit.vintage</groupId>
- <artifactId>junit-vintage-engine</artifactId>
- <scope>test</scope>
- </dependency>
- <dependency>
+<dependency>
Review Comment:
@Subhanshu20135 same
##########
drools-reliability/drools-reliability-tests/pom.xml:
##########
@@ -64,23 +64,12 @@
<artifactId>drools-engine</artifactId>
<scope>test</scope>
</dependency>
-
- <dependency>
- <groupId>junit</groupId>
- <artifactId>junit</artifactId>
- <scope>test</scope>
- </dependency>
- <dependency>
+<dependency>
<groupId>org.assertj</groupId>
<artifactId>assertj-core</artifactId>
<scope>test</scope>
</dependency>
- <dependency>
- <groupId>org.junit.vintage</groupId>
- <artifactId>junit-vintage-engine</artifactId>
- <scope>test</scope>
- </dependency>
- <dependency>
+<dependency>
Review Comment:
@Subhanshu20135 Same
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]