tkobayas commented on code in PR #7283:
URL: https://github.com/apache/incubator-kie/pull/7283#discussion_r4546947589
##########
drools-scenario-simulation/drools-scenario-simulation-backend/pom.xml:
##########
@@ -177,13 +177,4 @@
</dependency>
</dependencies>
- <profiles>
- <profile>
- <id>sonarcloud-analysis</id>
- <properties>
-
<sonar.coverage.exclusions>**/runner/DMNScenarioRunner.java,**/runner/RuleScenarioRunner.java</sonar.coverage.exclusions>
- </properties>
- </profile>
- </profiles>
-
</project>
Review Comment:
This looks like a leftover from the first commit. DMNScenarioRunner and
RuleScenarioRunner still exist, so please keep this Sonar exclusion as it is on
main.
##########
drools-scenario-simulation/drools-scenario-simulation-backend/pom.xml:
##########
@@ -177,13 +177,4 @@
</dependency>
</dependencies>
- <profiles>
- <profile>
- <id>sonarcloud-analysis</id>
- <properties>
-
<sonar.coverage.exclusions>**/runner/DMNScenarioRunner.java,**/runner/RuleScenarioRunner.java</sonar.coverage.exclusions>
Review Comment:
This looks like a leftover from the first commit. DMNScenarioRunner and
RuleScenarioRunner still exist, so please keep this Sonar exclusion as it is on
main.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]