MaximilianoSandillu opened a new issue, #2424:
URL: https://github.com/apache/incubator-kie-issues/issues/2424
### Description
The DMN Editor currently ships a single dictionary (`en`), registered in
`packages/dmn-editor/src/i18n/setup.ts` as `new Map([["en", en]])`.
I'd like to contribute a Spanish (`es`) translation of the DMN Editor UI
strings
(`packages/dmn-editor/src/i18n/locales/en.ts`, 333 own keys, 27 of them
function-valued).
I already have a draft that:
- keeps exactly the same keys and function signatures as `en.ts` (checked
with a script),
- preserves the `${"{...}"}` placeholders untouched,
- keeps DMN-specific terms untranslated (DRD, DRG, BKM, FEEL, Decision
Service, node type names),
- uses neutral Spanish.
### Proposed change
1. Add `packages/dmn-editor/src/i18n/locales/es.ts`.
2. Export it from `locales/index.ts`.
3. Register it in `setup.ts` (`["es", es]`), so it is picked up when the
editor is opened with `locale: "es"` (e.g. via
`@kie-tools/dmn-editor-standalone`).
### Questions
1. Are new locales welcome in this package? Is there any convention I should
follow
(file naming such as `es` vs `es_ES`, locale code, who reviews
translations)?
2. `en.ts` spreads `en_common` from `@kie-tools/i18n-common-dictionary`,
which has no Spanish dictionary.
Would you prefer that this PR:
a. falls back to `en_common` for those shared keys (my default), or
b. also adds a Spanish common dictionary there (I can do it in a
follow-up PR)?
3. Is anything else needed for the locale to be selectable (for example in
the standalone
package or in other editors that embed the DMN Editor)?
I'm happy to open the PR once the approach is confirmed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]