Kusuma04-dev commented on issue #2424:
URL: 
https://github.com/apache/incubator-kie-issues/issues/2424#issuecomment-6830570016

   Hi @MaximilianoSandillu ,
   Thank you for taking this up! Here are the answers to your questions:
   
   1. Are new locales welcome & conventions to follow?
   * Yes, new locales are very welcome!
   * File naming & locale code: Use the standard lowercase  code: es.ts and 
register it as ["es", es], consistent with the existing convention across the 
codebase (e.g., en.ts, de.ts).
   
   2. Handling @kie-tools/i18n-common-dictionary (Options a vs. b)
   * Preference: Option B (add es.ts to @kie-tools/i18n-common-dictionary in 
the same PR) is preferred.
   * @kie-tools/i18n-common-dictionary is lightweight, and including Spanish 
translations for common terms (cancel, confirm, save, etc.) in the same PR 
ensures a complete and consistent Spanish experience without leaving common UI 
elements in English.
   * If you prefer to keep this PR focused strictly on dmn-editor first, 
falling back to en_common (Option A) with a follow-up is also acceptable.
   
   3. What else is needed for the locale to be selectable?
   Once registered in dmnEditorDictionaries in 
packages/dmn-editor/src/i18n/setup.ts, it will be automatically picked up when 
locale: "es" is provided.
   For a completely localized experience, consider checking:
   1. packages/dmn-editor-envelope/src/i18n: Register es if there are 
envelope-level strings.
   2. Subcomponents (optional / follow-up): Dependent components embedded in 
the DMN Editor (such as @kie-tools/boxed-expression-component, 
@kie-tools/unitables-dmn, and @kie-tools/feel-input-component) also have their 
own src/i18n setups which can be translated in follow-up PRs.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to