Repository: kudu Updated Branches: refs/heads/master 062996ad7 -> 4adb27771
KUDU-1571 (follow-up): fix review comments from Mike Change-Id: I58175bc77d741474c3d80e202fc1ce96fb02ec55 Reviewed-on: http://gerrit.cloudera.org:8080/4082 Tested-by: Kudu Jenkins Reviewed-by: Mike Percy <[email protected]> Project: http://git-wip-us.apache.org/repos/asf/kudu/repo Commit: http://git-wip-us.apache.org/repos/asf/kudu/commit/4adb2777 Tree: http://git-wip-us.apache.org/repos/asf/kudu/tree/4adb2777 Diff: http://git-wip-us.apache.org/repos/asf/kudu/diff/4adb2777 Branch: refs/heads/master Commit: 4adb277711aad07c184bc0d51dbc94f60f2a756c Parents: 062996a Author: Todd Lipcon <[email protected]> Authored: Mon Aug 22 12:39:38 2016 -0700 Committer: Todd Lipcon <[email protected]> Committed: Mon Aug 22 22:41:36 2016 +0000 ---------------------------------------------------------------------- java/kudu-csd/check_csd_compatibility.py | 2 +- java/kudu-csd/generate_mdl.py | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/kudu/blob/4adb2777/java/kudu-csd/check_csd_compatibility.py ---------------------------------------------------------------------- diff --git a/java/kudu-csd/check_csd_compatibility.py b/java/kudu-csd/check_csd_compatibility.py index 46c561c..2c875c0 100755 --- a/java/kudu-csd/check_csd_compatibility.py +++ b/java/kudu-csd/check_csd_compatibility.py @@ -61,7 +61,7 @@ def check_mdl_compat(old_zip, new_zip, args): print "Added %d metric(s):" % len(added_metrics) for m_type, m_entity, m_name in added_metrics: print " %s metric %s" % (m_entity, m_name) - if len(removed_metrics): + if removed_metrics: print "Removed %d metric(s):" % len(removed_metrics) for m_type, m_entity, m_name in removed_metrics: print " %s metric %s" % (m_entity, m_name) http://git-wip-us.apache.org/repos/asf/kudu/blob/4adb2777/java/kudu-csd/generate_mdl.py ---------------------------------------------------------------------- diff --git a/java/kudu-csd/generate_mdl.py b/java/kudu-csd/generate_mdl.py index f2c562a..0fe054f 100755 --- a/java/kudu-csd/generate_mdl.py +++ b/java/kudu-csd/generate_mdl.py @@ -174,9 +174,9 @@ def metrics_to_mdl(metrics, historical_metrics): def main(): - all_metrics = load_current_metrics() + current_metrics = load_current_metrics() historical_metrics = load_historical_metrics() - metrics_by_entity = metrics_to_mdl(all_metrics, historical_metrics) + metrics_by_entity = metrics_to_mdl(current_metrics, historical_metrics) server_metrics = metrics_by_entity['server'] tablet_metrics = metrics_by_entity['tablet']
