zhouyifan279 commented on a change in pull request #1119:
URL: https://github.com/apache/incubator-kyuubi/pull/1119#discussion_r711519521



##########
File path: kyuubi-server/src/main/scala/org/apache/kyuubi/engine/EngineRef.scala
##########
@@ -182,6 +182,7 @@ private[kyuubi] class EngineRef(
           }
         }
         if (started + timeout <= System.currentTimeMillis()) {
+          builder.closeYarnJob()

Review comment:
       Maybe `killApplication` is a more suitable method name as engine may be 
submitted to other Cluster Managers such as kubernetes.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to