pan3793 commented on a change in pull request #1119:
URL: https://github.com/apache/incubator-kyuubi/pull/1119#discussion_r711532175



##########
File path: 
kyuubi-server/src/test/scala/org/apache/kyuubi/engine/spark/SparkProcessBuilderSuite.scala
##########
@@ -225,6 +224,21 @@ class SparkProcessBuilderSuite extends 
KerberizedTestHelper {
     val b2 = new SparkProcessBuilder("test", conf)
     assert(b2.mainResource.getOrElse("") != jarPath.toString)
   }
+
+  test("test kill application") {
+    val config = KyuubiConf()
+    val pb: FakeSparkProcessBuilder = new FakeSparkProcessBuilder(config)
+    val lastRowOfLog = "Application report for application_1593587619692_19713 
(state: ACCEPTED)"
+
+    val e = intercept[KyuubiSQLException] {
+      pb.killApplication(lastRowOfLog)
+    }
+
+    assert(e.getMessage === "Failed to kill yarn job. " +

Review comment:
       It's not a robust test. The test will fail if the user set `HADOOP_HOME` 
in their machine.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to