yaooqinn commented on a change in pull request #1160:
URL: https://github.com/apache/incubator-kyuubi/pull/1160#discussion_r716202791
##########
File path:
kyuubi-server/src/main/scala/org/apache/kyuubi/session/KyuubiSessionManager.scala
##########
@@ -31,6 +32,12 @@ class KyuubiSessionManager private (name: String) extends
SessionManager(name) {
def this() = this(classOf[KyuubiSessionManager].getSimpleName)
+ override def LOG_ROOT: String = if (Utils.isTesting) {
+ "target/server_operation_logs"
+ } else {
+ conf.get(SERVER_OPERATION_LOG_DIR_ROOT).getOrElse("server_operation_logs")
Review comment:
it seems that we need to pre-touch or validate the root dir
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]