pan3793 commented on a change in pull request #1177:
URL: https://github.com/apache/incubator-kyuubi/pull/1177#discussion_r719085787
##########
File path:
kyuubi-ha/src/main/scala/org/apache/kyuubi/ha/client/ZooKeeperACLProvider.scala
##########
@@ -33,11 +33,20 @@ class ZooKeeperACLProvider(conf: KyuubiConf) extends
ACLProvider {
*/
override lazy val getDefaultAcl: java.util.List[ACL] = {
val nodeAcls = new java.util.ArrayList[ACL]
- if (conf.get(HighAvailabilityConf.HA_ZK_ACL_ENABLED)) {
+
+ def addACL(): Unit = {
// Read all to the world
nodeAcls.addAll(ZooDefs.Ids.READ_ACL_UNSAFE)
// Create/Delete/Write/Admin to the authenticated user
nodeAcls.addAll(ZooDefs.Ids.CREATOR_ALL_ACL)
+ }
+
+ if (conf.get(HighAvailabilityConf.HA_ZK_ACL_ENABLED) &&
+ conf.get(HighAvailabilityConf.HA_ZK_ENGINE_REF_ID).isEmpty) {
Review comment:
@ulysses-you does this sufficient to distinguish between the server side
and the engine side?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
