[GitHub] [incubator-kyuubi] cxzl25 commented on a change in pull request #1177: [KYUUBI #1176] InvalidACL appears in the engine when zookeeper acl is turned on

Wed, 29 Sep 2021 23:41:17 -0700 


cxzl25 commented on a change in pull request #1177:
URL: https://github.com/apache/incubator-kyuubi/pull/1177#discussion_r719102228



##########
File path: 
kyuubi-ha/src/main/scala/org/apache/kyuubi/ha/client/ZooKeeperACLProvider.scala
##########
@@ -33,11 +33,20 @@ class ZooKeeperACLProvider(conf: KyuubiConf) extends 
ACLProvider {
    */
   override lazy val getDefaultAcl: java.util.List[ACL] = {
     val nodeAcls = new java.util.ArrayList[ACL]
-    if (conf.get(HighAvailabilityConf.HA_ZK_ACL_ENABLED)) {
+
+    def addACL(): Unit = {
       // Read all to the world
       nodeAcls.addAll(ZooDefs.Ids.READ_ACL_UNSAFE)
       // Create/Delete/Write/Admin to the authenticated user
       nodeAcls.addAll(ZooDefs.Ids.CREATOR_ALL_ACL)
+    }
+
+    if (conf.get(HighAvailabilityConf.HA_ZK_ACL_ENABLED) &&
+      conf.get(HighAvailabilityConf.HA_ZK_ENGINE_REF_ID).isEmpty) {

Review comment:
       I don’t seem to find other ways to distinguish server and engine, or use 
main class to distinguish.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to